Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for excluding some tests per-stream #1002

Closed
jlebon opened this issue Jun 14, 2024 · 2 comments
Closed

Add support for excluding some tests per-stream #1002

jlebon opened this issue Jun 14, 2024 · 2 comments
Assignees
@marmijo
Labels
jira For syncing to JIRA

Comments

@jlebon
Copy link
Member

jlebon commented Jun 14, 2024

With the new rhel-9.4 and c9s streams added in openshift/os#1445, we need to be able to run kola tests but skipping those that are specific to OpenShift. Those ones have already been tagged with openshift (example). So basically, we need a stream-level knob that in practice boils down to --tag !openshift when we run kola.

E.g. something like:

streams:
  rhel-9.4:
    skip_kola_tags: [openshift]

?

(So at least it's generic over the tag name.)
@jlebon jlebon added the jira For syncing to JIRA label Jun 14, 2024
marmijo added a commit to marmijo/coreos-ci-lib that referenced this issue Jun 21, 2024
@marmijo
vars/kola: Add support for skipping a list of kola tags
ae71017 
Introduce a kola parameter to allow skipping a list of kola tags.
This is particularly useful when adding new streams to the pipeline.

xref: https://github.com/coreos/fedora-coreos-pipeline/pulls/####

Reference: coreos/fedora-coreos-pipeline#1002
@marmijo marmijo mentioned this issue Jun 21, 2024
Merged
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Jun 21, 2024
@marmijo
jobs/build: add support for stream level skip_kola_tags knob
bebc4d2 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: https://github.com/coreos/coreos-ci-lib/pulls/159

See: coreos#1002
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Jun 21, 2024
@marmijo
jobs/build: add support for stream level skip_kola_tags knob
c3faa18 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: coreos/coreos-ci-lib#159

See: coreos#1002
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Jun 21, 2024
@marmijo
jobs/build: add support for stream level skip_kola_tags knob
ba17d94 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: coreos/coreos-ci-lib#159

See: coreos#1002
@marmijo marmijo mentioned this issue Jun 21, 2024
Merged
marmijo added a commit to marmijo/coreos-ci-lib that referenced this issue Jun 21, 2024
@marmijo
vars/kola: Add support for skipping a list of kola tags
6e02c18 
Introduce a kola parameter to allow skipping a list of kola tags.
This is particularly useful when adding new streams to the pipeline.

xref: coreos/fedora-coreos-pipeline#1008

Reference: coreos/fedora-coreos-pipeline#1002
@marmijo
Copy link
Contributor

marmijo commented Jun 21, 2024 •
edited
Loading

I opened a few PRs to solve this issue:

marmijo added a commit to marmijo/coreos-ci-lib that referenced this issue Jun 21, 2024
@marmijo
vars/kola: Add support for skipping a list of kola tags
1c56ae7 
Introduce a kola parameter to allow skipping a list of kola tags.
This is particularly useful when adding new streams to the pipeline.

xref: coreos/fedora-coreos-pipeline#1008

Reference: coreos/fedora-coreos-pipeline#1002
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Jun 21, 2024
@marmijo
jobs/build: add support for stream level skip_kola_tags knob
11b05fc 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: coreos/coreos-ci-lib#159

See: coreos#1002
marmijo added a commit to marmijo/fedora-coreos-pipeline that referenced this issue Jun 21, 2024
@marmijo
jobs/build: add support for stream level skip_kola_tags knob
0875e63 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: coreos/coreos-ci-lib#159

See: coreos#1002
marmijo added a commit to marmijo/coreos-ci-lib that referenced this issue Jun 21, 2024
@marmijo
vars/kola: Add support for skipping a list of kola tags
705a161 
Introduce a kola parameter to allow skipping a list of kola tags.
This is particularly useful when adding new streams to the pipeline.

xref: coreos/fedora-coreos-pipeline#1008

Reference: coreos/fedora-coreos-pipeline#1002
jlebon pushed a commit to coreos/coreos-ci-lib that referenced this issue Jun 21, 2024
@marmijo @jlebon
vars/kola: Add support for skipping a list of kola tags
954e002 
Introduce a kola parameter to allow skipping a list of kola tags.
This is particularly useful when adding new streams to the pipeline.

xref: coreos/fedora-coreos-pipeline#1008

Reference: coreos/fedora-coreos-pipeline#1002
jlebon pushed a commit that referenced this issue Jun 21, 2024
@marmijo @jlebon
jobs/build: add support for stream level skip_kola_tags knob
dc58259 
Kola can now support skipping kola tags per stream[1]. Add support
for that here by modifying each Jenkins job to pass the list of
kola tags to skip to the kola function.

[1]: coreos/coreos-ci-lib#159

See: #1002
@marmijo
Copy link
Contributor

marmijo commented Jun 26, 2024

Closing as completed.

@marmijo marmijo closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmijo marmijo

Labels
jira For syncing to JIRA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlebon @marmijo