Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: regenerate sources for etcd/client with new ugorji/go changes #8574

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

abronan
Copy link
Contributor

@abronan abronan commented Sep 19, 2017

Major updates to ugorji/go changed the signature of some
methods, resulting in the build failing for etcd/client.

We regenerate the sources using codecgen to reflect on the
new changes.

Fixes #8573

Signed-off-by: Alexandre Beslic abeslic@abronan.com

@gyuho
Copy link
Contributor

gyuho commented Sep 19, 2017

@abronan Could you format your git commit title to client: regenerate ...? Thanks!

@abronan
Copy link
Contributor Author

abronan commented Sep 19, 2017

@gyuho Sure thing.

Also, any idea on why the build fails with semaphore? Not really familiar to it. Thanks!

Major updates to ugorji/go changed the signature of some
methods, resulting in the build failing for etcd/client
with default installation of the codec.

We regenerate the sources using codecgen with the new version
to reflect on the new changes.

Fixes etcd-io#8573

Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
@abronan abronan changed the title Codecgen: regenerate sources for etcd/client Client: regenerate sources for etcd/client with new ugorji/go changes Sep 19, 2017
@gyuho
Copy link
Contributor

gyuho commented Sep 19, 2017

lgtm. Defer to @heyitsanthony

Thanks!

@gyuho gyuho changed the title Client: regenerate sources for etcd/client with new ugorji/go changes client: regenerate sources for etcd/client with new ugorji/go changes Sep 20, 2017
@gyuho gyuho merged commit aca8a0d into etcd-io:master Sep 20, 2017
@abronan abronan deleted the regenerate_keys branch September 20, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants