client: regenerate sources for etcd/client with new ugorji/go changes #8574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abronan
force-pushed
the
regenerate_keys
branch
from
40efb6e
to
8bf9329
Compare
|
@abronan Could you format your git commit title to |
|
@gyuho Sure thing. Also, any idea on why the build fails with semaphore? Not really familiar to it. Thanks! |
Major updates to ugorji/go changed the signature of some methods, resulting in the build failing for etcd/client with default installation of the codec. We regenerate the sources using codecgen with the new version to reflect on the new changes. Fixes etcd-io#8573 Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
abronan
force-pushed
the
regenerate_keys
branch
from
8bf9329
to
8dc4833
Compare
abronan
changed the title
|
lgtm. Defer to @heyitsanthony Thanks! |
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major updates to ugorji/go changed the signature of some
methods, resulting in the build failing for etcd/client.
We regenerate the sources using codecgen to reflect on the
new changes.
Fixes #8573
Signed-off-by: Alexandre Beslic abeslic@abronan.com