-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds broken with latest go-codec change #8579
Comments
Duplicate #8573? |
Recent git master 54210f4e076c57f351166f0ed60e67d3fca57a36 of github.com/ugorji/go broke the builds. See: etcd-io/etcd#8579
yeah I think so. I searched issues, but didn't see it, sorry. I'd close that one as this one has more information, but it's up to you, and it's definitely a dupe :) |
Closing via #8574. Thanks. |
Thanks! (Could we use this opportunity to unvendor libs like this that don't need to be stuck at a specific version?) |
LMK if you'd like a patch for that. |
@purpleidea |
Recent git master 54210f4e076c57f351166f0ed60e67d3fca57a36 of github.com/ugorji/go broke the builds. See: etcd-io/etcd#8579
Recently ~23h ago:
ugorji/go@54210f4#diff-46a6c1a93a41b9397422576c715bf9f6L731
DecodeBytes changed from:
to:
Etcd is using the old version here: https://github.com/coreos/etcd/blob/5bb9f9591f01d0a3c61d2eb3a3bb281726005b2b/client/keys.generated.go#L192 (current git master)
This broke all the builds using git master, and will be yet another thing to track down and fix if we ever want to increase the go-codec version. This is one of the reasons I argue against vendoring anything that doesn't require vendoring, because it makes it hard to move everything forward, instead of fixing one small thing at a time.
It was caught here: https://travis-ci.org/purpleidea/mgmt/jobs/277369429#L779 in our cron tests for https://github.com/purpleidea/mgmt/ since we use only the minimal subset of etcd that requires vendoring.
The text was updated successfully, but these errors were encountered: