Builds broken with latest go-codec change

[purpleidea]

Recently ~23h ago:

ugorji/go@54210f4#diff-46a6c1a93a41b9397422576c715bf9f6L731

DecodeBytes changed from:

DecodeBytes(bs []byte, isstring, zerocopy bool) (bsOut []byte)

to:

DecodeStringAsBytes() (s []byte)

Etcd is using the old version here: https://github.com/coreos/etcd/blob/5bb9f9591f01d0a3c61d2eb3a3bb281726005b2b/client/keys.generated.go#L192 (current git master)

This broke all the builds using git master, and will be yet another thing to track down and fix if we ever want to increase the go-codec version. This is one of the reasons I argue against vendoring anything that doesn't require vendoring, because it makes it hard to move everything forward, instead of fixing one small thing at a time.

It was caught here: https://travis-ci.org/purpleidea/mgmt/jobs/277369429#L779 in our cron tests for https://github.com/purpleidea/mgmt/ since we use only the minimal subset of etcd that requires vendoring.

[gyuho]

Duplicate #8573?

[purpleidea]

@gyuho

yeah I think so. I searched issues, but didn't see it, sorry. I'd close that one as this one has more information, but it's up to you, and it's definitely a dupe :)

[gyuho]

Closing via #8574.

Thanks.

[purpleidea]

Thanks! (Could we use this opportunity to unvendor libs like this that don't need to be stuck at a specific version?)

[purpleidea]

LMK if you'd like a patch for that.

[gyuho]

@purpleidea github.com/ugorji/go/codec still needs to be vendored for etcd/client package. Even if it's only for generated code, seems like a good idea to have pinned version of it in glide.yaml.