-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to go get client #8573
Comments
Bah. 1.9+ required shown in documentation. Sorry to bother. |
|
Experiencing the same thing here with |
Could be related to changes in package https://github.com/ugorji/go/codec? Interface has changed: https://github.com/ugorji/go/blob/master/codec/decode.go#L94-L95 |
same problem here |
Major updates to ugorji/go changed the signature of some methods, resulting in the build failing for etcd/client. We regenerate the sources using codecgen to reflect on the new changes. Fixes etcd-io#8573 Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
Major updates to ugorji/go changed the signature of some methods, resulting in the build failing for etcd/client with default installation of the codec. We regenerate the sources using codecgen with the new version to reflect on the new changes. Fixes etcd-io#8573 Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
Major updates to ugorji/go changed the signature of some methods, resulting in the build failing for etcd/client with default installation of the codec. We regenerate the sources using codecgen with the new version to reflect on the new changes. Fixes etcd-io#8573 Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
I just got bitten by this too. Go 1.9 amd64 As a possibly interesting side note that ugorji/codec import adds 6.5M to the size of my binaries, basically doubling them in size. It's imported by both etcd and prometheus packages and is by far the largest sized import. If you're using only a limited functionallity from that package (I don't know if you are) then it may be worth reducing your dependency on pulling in the whole package. This can tell you the binary size of each package in your build:
|
@nulladmin What etcd packages are you vendoring? If you think it's unusual, please open a new issue. Thanks. |
Bug? - Failing to get client
go get github.com/coreos/etcd/client
On my computer and on CI. Go version 1.8.3. Are there any changes I should be aware of ?
Kind regards,
M.
The text was updated successfully, but these errors were encountered: