-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: snapshotter's failure is not propogated #16588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - create a dummy pipe to propogate the error - add unit tests to verify it
yihuang
added
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
labels
Jun 16, 2023
github-prbot
requested review from
a team,
alexanderbez and
julienrbrt
and removed request for
a team
June 16, 2023 08:07
yihuang
commented
Jun 16, 2023
tac0turtle
approved these changes
Jun 16, 2023
facundomedica
approved these changes
Jun 16, 2023
julienrbrt
approved these changes
Jun 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Could you fix linting?
done |
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2023
(cherry picked from commit aeccbc9)
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2023
(cherry picked from commit aeccbc9) # Conflicts: # snapshots/manager_test.go # store/CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2023
(cherry picked from commit aeccbc9) # Conflicts: # store/CHANGELOG.md
tac0turtle
pushed a commit
that referenced
this pull request
Jun 19, 2023
tac0turtle
pushed a commit
that referenced
this pull request
Jun 19, 2023
GAtom22
pushed a commit
to evmos/cosmos-sdk
that referenced
this pull request
Jul 12, 2023
…osmos#16604) Co-authored-by: yihuang <huang@crypto.com>
GAtom22
pushed a commit
to evmos/cosmos-sdk
that referenced
this pull request
Jul 12, 2023
…osmos#16604) Co-authored-by: yihuang <huang@crypto.com>
cmwaters
added a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
* build(deps): bump cometbft to v0.34.29 (cosmos#16553) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604) Co-authored-by: yihuang <huang@crypto.com> * feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823) Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: HuangYi <huang@crypto.com> * fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: query tx events with `>=` and `<=` operators (cosmos#16994) * docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019) * chore: prepare v0.46.14 (cosmos#16879) * refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <itsdevbear@berachain.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <julien@rbrt.fr> --------- Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: Devon Bear <itsdevbear@berachain.com>
19 tasks
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…osmos#16604) Co-authored-by: yihuang <huang@crypto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
backport/v0.50.x
PR scheduled for inclusion in the v0.50's next stable release
backport/0.46.x
PR scheduled for inclusion in the v0.46's next stable release
C:Store
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A invalid export call will create an empty snapshot, instead of a failure.
Solution:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change