Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add MigrateHandler to allow reuse migrate genesis related function #17296

Merged
merged 2 commits into from
Aug 7, 2023
Merged

refactor: add MigrateHandler to allow reuse migrate genesis related function #17296

merged 2 commits into from
Aug 7, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 7, 2023

Description

Updates: crypto-org-chain/cronos#1124

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Aug 7, 2023
@mmsqe mmsqe marked this pull request as ready for review August 7, 2023 01:53
@mmsqe mmsqe requested a review from a team as a code owner August 7, 2023 01:53
julienrbrt
julienrbrt approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 7, 2023
@julienrbrt
Copy link
Member

FYI: The idea in v0.50 is to wrap the MigrationMap from the SDK to add the app custom migration.

@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Aug 7, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 7, 2023
Merged via the queue into cosmos:main with commit 7a778f5 Aug 7, 2023
45 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@mmsqe @mergify
refactor: add MigrateHandler to allow reuse migrate genesis related f…
389c902 
…unction (#17296)

(cherry picked from commit 7a778f5)
@mergify mergify bot mentioned this pull request Aug 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@mmsqe @mergify
refactor: add MigrateHandler to allow reuse migrate genesis related f…
61023e4 
…unction (#17296)

(cherry picked from commit 7a778f5)

# Conflicts:
#	CHANGELOG.md
#	x/genutil/client/cli/migrate.go
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@mmsqe @mergify
refactor: add MigrateHandler to allow reuse migrate genesis related f…
489a66f 
…unction (#17296)

(cherry picked from commit 7a778f5)

# Conflicts:
#	CHANGELOG.md
#	x/genutil/client/cli/migrate.go
This was referenced Aug 7, 2023
Merged
Merged
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@mergify @mmsqe @julienrbrt
refactor: add MigrateHandler to allow reuse migrate genesis related f…
6e075c5 
…unction (backport #17296) (#17299)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@mergify @mmsqe @julienrbrt
refactor: add MigrateHandler to allow reuse migrate genesis related f…
16d5269 
…unction (backport #17296) (#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@mergify @mmsqe @julienrbrt
refactor: add MigrateHandler to allow reuse migrate genesis related f…
b3f0567 
…unction (backport #17296) (#17300)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
cmwaters added a commit to celestiaorg/cosmos-sdk that referenced this pull request Aug 15, 2023
@cmwaters @julienrbrt
@mergify @odeke-em @yihuang @mmsqe @tac0turtle @KyleMoser @rootulp @itsdevbear
chore: bump sdk to v0.46.14 and tm to v1.26.2-tm-v0.34.28 (#340)
64adc6e 
* build(deps): bump cometbft to v0.34.29 (cosmos#16553)

* fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570)

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604)

Co-authored-by: yihuang <huang@crypto.com>

* feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823)

Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>

* fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: query tx events with `>=` and `<=` operators (cosmos#16994)

* docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019)

* chore: prepare v0.46.14 (cosmos#16879)

* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <julien@rbrt.fr>

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
@faddat faddat mentioned this pull request Sep 5, 2023
Closed
19 tasks
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@faddat faddat mentioned this pull request Oct 15, 2023
Closed
19 tasks
rootulp pushed a commit to rootulp/cosmos-sdk that referenced this pull request Nov 7, 2023
@mergify @mmsqe
@julienrbrt @rootulp
refactor: add MigrateHandler to allow reuse migrate genesis related f…
980949b 
…unction (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
rootulp added a commit to celestiaorg/cosmos-sdk that referenced this pull request Nov 14, 2023
@rootulp @mergify
@mmsqe @julienrbrt @itsdevbear @devon-chain @fmorency @bryanchriswhite @tac0turtle
chore: upgrade to cosmos-sdk v0.46.16 (#357)
e04d485 
* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare v0.46.15 (cosmos#17408)

* fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527)

Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549)

Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>

* fix: typo in comment (backport cosmos#17635) (cosmos#17638)

Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>

* build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare release notes v0.46.16 (cosmos#18118)

* fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: update tag date v0.46.16 (cosmos#18385)

* revert: Go 1.19

* revert: c226e8b

* chore(deps): upgrade to v1.29.0-tm-v0.34.29

* chore: downgrade to grpc 1.54.0

to match the versions used in upstream

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com>
Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @julienrbrt