Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): improve prune command ux #16856

Merged
merged 7 commits into from
Jul 7, 2023
Merged

fix(cli): improve prune command ux #16856

merged 7 commits into from
Jul 7, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 6, 2023 •
edited
Loading

Description

Closes: #16855

Right now, passing the home flag is mandatory otherwise it panics. It isn't a great UX, as every other SDK commands do not require to always pass a flag.

Looking as well now how to make the ux for this command better.
In the backport, I'll do it non-breaking for v0.46 and v0.47.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 6, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 6, 2023 11:10
@github-actions github-actions bot added the C:CLI label Jul 6, 2023
@github-actions

This comment has been minimized.

Sign in to view
@julienrbrt julienrbrt added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jul 6, 2023
alexanderbez
alexanderbez approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

client/pruning/main.go
cmd := &cobra.Command{
Use: "prune",
Use: "prune [pruning-method]",
Short: "Prune app history states by keeping the recent heights and deleting old heights",
Long: `Prune app history states by keeping the recent heights and deleting old heights.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm the output of this displays nicely and is formatted correctly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spacing issue, let me fix it.

@julienrbrt julienrbrt enabled auto-merge July 7, 2023 10:07
@julienrbrt julienrbrt added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit 317fb0b Jul 7, 2023
@julienrbrt julienrbrt deleted the julien/impr-ux-prune-cmd branch July 7, 2023 10:23
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@julienrbrt @mergify
fix(cli): improve prune command ux (#16856)
7c6938c 
(cherry picked from commit 317fb0b)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@julienrbrt @mergify
fix(cli): improve prune command ux (#16856)
60f98a7 
(cherry picked from commit 317fb0b)

# Conflicts:
#	CHANGELOG.md
#	client/pruning/main.go
#	simapp/simd/cmd/root.go
#	simapp/simd/cmd/root_v2.go
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@julienrbrt @mergify
fix(cli): improve prune command ux (#16856)
d910cb7 
(cherry picked from commit 317fb0b)

# Conflicts:
#	CHANGELOG.md
#	client/pruning/main.go
#	simapp/simd/cmd/root.go
#	simapp/simd/cmd/root_v2.go
This was referenced Jul 7, 2023
Merged
Merged
Merged
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@mergify @julienrbrt
fix(cli): improve prune command ux (backport #16856) (#16874)
2809154 
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@mergify @julienrbrt
fix(cli): improve prune command ux (backport #16856) (#16876)
7458047 
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@mergify @julienrbrt
fix(cli): improve prune command ux (backport #16856) (#16875)
54db420 
Co-authored-by: Julien Robert <julien@rbrt.fr>
GAtom22 pushed a commit to evmos/cosmos-sdk that referenced this pull request Jul 12, 2023
@mergify @julienrbrt @GAtom22
fix(cli): improve prune command ux (backport cosmos#16856) (cosmos#…
931a16e 
…16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>
GAtom22 pushed a commit to evmos/cosmos-sdk that referenced this pull request Jul 12, 2023
@mergify @julienrbrt @GAtom22
fix(cli): improve prune command ux (backport cosmos#16856) (cosmos#…
50ec2e9 
…16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@jacksoom jacksoom mentioned this pull request Jul 29, 2023
Merged
cmwaters added a commit to celestiaorg/cosmos-sdk that referenced this pull request Aug 15, 2023
@cmwaters @julienrbrt
@mergify @odeke-em @yihuang @mmsqe @tac0turtle @KyleMoser @rootulp @itsdevbear
chore: bump sdk to v0.46.14 and tm to v1.26.2-tm-v0.34.28 (#340)
64adc6e 
* build(deps): bump cometbft to v0.34.29 (cosmos#16553)

* fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570)

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604)

Co-authored-by: yihuang <huang@crypto.com>

* feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823)

Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>

* fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: query tx events with `>=` and `<=` operators (cosmos#16994)

* docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019)

* chore: prepare v0.46.14 (cosmos#16879)

* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <julien@rbrt.fr>

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
@faddat faddat mentioned this pull request Sep 5, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Oct 15, 2023
Closed
19 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @julienrbrt @JeancarloBarrios
fix(cli): improve prune command ux (backport cosmos#16856) (cosmos#…
d33847b 
…16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: new function prune panics at v0.47.3
2 participants
@julienrbrt @alexanderbez