Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.37.8-RC1 Cherry Picks #5777

Merged
merged 7 commits into from
Mar 11, 2020
Merged

v0.37.8-RC1 Cherry Picks #5777

merged 7 commits into from
Mar 11, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 10, 2020

Closes: #5716


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #5777 into rc1/v0.37.8 will increase coverage by 0.00%.
The diff coverage is 24.52%.

@@             Coverage Diff              @@
##           rc1/v0.37.8    #5777   +/-   ##
============================================
  Coverage        51.34%   51.35%           
============================================
  Files              290      290           
  Lines            18896    18900    +4     
============================================
+ Hits              9703     9706    +3     
  Misses            8501     8501           
- Partials           692      693    +1     

@alexanderbez alexanderbez merged commit b611c32 into rc1/v0.37.8 Mar 11, 2020
@alexanderbez alexanderbez deleted the rc0/v0.37.8 branch March 11, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants