Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main into Eureka feature branch #7299

Merged
merged 41 commits into from
Sep 17, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Sep 17, 2024

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

haouvw and others added 30 commits August 26, 2024 14:46
Signed-off-by: haouvw <jchaodaohang@foxmail.com>
* migrate context part 1

* ++

* ++

* ++

* ++

* ++fafo

* linting

* linting

* nit: rename arg from key -> storeService

* chore: rm redundant import aliases (linter)

* chore: consistent import aliasing of corestore, godoc nit, apease linter

* chore: more corestore import aliasing consistency and var naming localhost client mod

* ammend comments

* remove todo

* add back panic

* chore: update ibc commitment prefix with exported.StoreKey const in favour of hardcoded string

* refactor: make panics consistent on store ops

* chore: update TODOs in code to link to issue

* chore: keep conditionals as they were

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
* chore: replace expected boolean errors with expected errors

* use errors rather than strings

* last tests

* linter

* introduce testing aux function

* Update modules/apps/29-fee/ibc_middleware_test.go

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Missing file

* mark function as helper

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* migrate context part 1

* ++

* ++

* ++

* ++

* ++fafo

* p2

* fix todos

* error checks

* fix build

* fix build for wasm

* ignore linting

* fix(test): reorder logic to fix failing OnChanOpenInit ica tests

* chore(tests): use valid id for channel.

* chore(linter): fix linter madness

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
* chore: expect specific errors in apps/transfer

* revert changed line

* mark function as helper

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.38.0...v1.39.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#7215)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.65.0 to 1.66.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.65.0...v1.66.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump google.golang.org/grpc from 1.65.0 to 1.66.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.65.0 to 1.66.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.65.0...v1.66.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: make tidy-all

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
* chore (api)\!: remove capabilities from SendPacket

* add changelog + note to add migration documentation

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* deps: bump ics23 to v0.11.0

* fix typo
* chore (api)!: remove capabilities from WriteAcknowledgment.

* revert wrong change

* Add changelog and docs placeholder
* migrate context part 1

* ++

* ++

* ++

* ++

* ++fafo

* p2

* capability changes

* fix capability

* remove todos

* linting

* build

* fix build

* add missing replace

* fix capability tests

* chore(linter): fix linter madness

* Apply suggestions from code review

* Update modules/capability/keeper/keeper.go

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

* nit: has -> isInitialized

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
* migrate context part 1

* ++

* ++

* ++

* ++

* ++fafo

* p2

* capability changes

* fix capability

* remove todos

* linting

* build

* more context cleanup

* more cleanup

* fix unwrap

* chore(linter): fix linter madness

* chore: replace TODOs with issue number

* chore(linter): fix linter madness

* Update modules/apps/27-interchain-accounts/host/keeper/relay.go

* chore: remove todo in favour of migrations issue

* Update modules/apps/27-interchain-accounts/host/keeper/migrations.go

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
* almost all tests working

* fix last tests

* solve merge error

* remove newline

* fix comment

* docstring

* docs

* Update modules/core/keeper/msg_server.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* pr feedback

* change error message

* forgot to save a file...

* merge error

---------

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* chore: remove exp pkg

* sort keys
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.3 to 4.6.4.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.6.3...v4.6.4)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6...v7)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#7247)

* chore(deps): bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12

Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.38.11 to 0.38.12.
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/v0.38.12/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.38.11...v0.38.12)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: make tidy-all

* update changelog

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* remove unneeded methods

* Remvoed capabilites, need to remove tests

* fix tests

* Changelod and further removal
* chore (api)! remove LookupModuleByPort

* Update CHANGELOG.md

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
* chore: after v7.8.0 and v8.5.0

* set latest docs version

* rename sidebars json files
* docs: discourage usage of source callbacks in memo field

* extra clarifications

* Update docs/docs/04-middleware/02-callbacks/01-overview.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

---------

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.39.0 to 1.40.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.39.0...v1.40.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.20.0 to 0.21.0.
- [Commits](golang/mod@v0.20.0...v0.21.0)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump cosmossdk.io/store from 1.1.0 to 1.1.1

Bumps [cosmossdk.io/store](https://github.com/cosmos/cosmos-sdk) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@log/v1.1.0...math/v1.1.1)

---
updated-dependencies:
- dependency-name: cosmossdk.io/store
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump all modules

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.40.0 to 1.40.1.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.40.0...v1.40.1)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* some improvements

* alignment

* more alignment
damiannolan and others added 11 commits September 10, 2024 11:31
#7274)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.0 to 1.66.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/commits)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: remove more capabilities

* chore: make lint-fix

* chore: rm export test method

* chore: make tidy-all

* refactor: remove capabilities

* add migration entry

* chore: add changelog

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
…#7279)

* chore: remove references to capabilities in comments, plus unused methods

* removed capabilities module and more references

* remove capability workflows and proto

* Changelog
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.0 to 1.66.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/commits)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
…lver (#7277)

* fix: attempt to fix panics for unresolvable imports by using GogoResolver

* chore: add changelog

* chore: amend changelog
* chore(deps): bump google.golang.org/grpc from 1.66.0 to 1.66.1

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.0 to 1.66.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/commits)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): make tidy-all

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
…7286)

Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 16 to 17.
- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)
- [Commits](DavidAnson/markdownlint-cli2-action@v16...v17)

---
updated-dependencies:
- dependency-name: DavidAnson/markdownlint-cli2-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.40.1 to 1.41.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.40.1...v1.41.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump google.golang.org/grpc from 1.66.1 to 1.66.2

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.1 to 1.66.2.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.66.1...v1.66.2)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump modules

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM went through merge conflicts together

Copy link

sonarcloud bot commented Sep 17, 2024

@chatton chatton changed the base branch from feat/ibc-eureka to feat/ibc-eureka-2 September 17, 2024 10:33
@chatton chatton merged commit c313dbb into feat/ibc-eureka-2 Sep 17, 2024
64 of 66 checks passed
@chatton chatton deleted the bznein/eureka/mergemain branch September 17, 2024 10:33
@chatton chatton restored the bznein/eureka/mergemain branch September 17, 2024 10:34
@chatton
Copy link
Contributor

chatton commented Sep 17, 2024

tested this on a separate branch to double check the merge conflicts went through as expected (they did! Doing it for real in #7300 )

@chatton chatton deleted the bznein/eureka/mergemain branch September 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants