Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: if chanid includes 2 or more '-' , chain_version always returns 0 #80

Closed
5 tasks
leejw51crypto opened this issue Apr 30, 2021 · 0 comments · Fixed by informalsystems/hermes#879
Closed
5 tasks
Assignees
Labels
A: bug Admin: something isn't working

Comments

@leejw51crypto
Copy link

Crate

ibc

Summary of Bug

when chain id contains two '-',
chain_version return 0 as revision number
instead of last digit

Version

c32393a

Steps to Reproduce

when chainid is like
testnet-helloworld-2

Acceptance Criteria

when chainid is like above, it works without issues


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
leejw51crypto referenced this issue in leejw51crypto/ibc-rs Apr 30, 2021
@adizere adizere added the A: bug Admin: something isn't working label Apr 30, 2021
@adizere adizere self-assigned this Apr 30, 2021
adizere referenced this issue in informalsystems/hermes Apr 30, 2021
use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>
leejw51crypto referenced this issue in leejw51crypto/ibc-rs May 3, 2021
adizere referenced this issue in informalsystems/hermes May 3, 2021
…shes (#884)

* Solution: use the last digit (fix #878) (#879)

use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>

* Doc tests and FMT

* Changelog

Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Co-authored-by: jongwhan lee <leejw51@gmail.com>
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
…shes (informalsystems#884)

* Solution: use the last digit (fix #878) (informalsystems#879)

use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>

* Doc tests and FMT

* Changelog

Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Co-authored-by: jongwhan lee <leejw51@gmail.com>
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
* made Msg trait global

* remove associated type Header from MsgCreateClient
livelybug referenced this issue in octopus-network/ibc-rs Oct 14, 2022
* made Msg trait global

* remove associated type Header from MsgCreateClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants