Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution: use the last digit from chain-id #879

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Solution: use the last digit from chain-id #879

merged 1 commit into from
Apr 30, 2021

Conversation

leejw51crypto
Copy link
Contributor

@leejw51crypto leejw51crypto commented Apr 30, 2021 •
edited by adizere
Loading

First commits towards closing cosmos/ibc-rs#80

Description

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

adizere
adizere requested changes Apr 30, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I left one suggestion for improvement. Please take the suggestion into account if you have time (otherwise, no problem, one of the repo owners will try to).

modules/src/ics24_host/identifier.rs Show resolved Hide resolved
@adizere adizere changed the base branch from master to adi/879 April 30, 2021 17:14
@adizere
Copy link
Member

adizere commented Apr 30, 2021

Again, many thanks @leejw51crypto for your contribution!

I will merge this PR and continue development of this work in the branch informalsystems:adi/879. I hope that's okay with you.

@adizere adizere merged commit 38ee7a4 into informalsystems:adi/879 Apr 30, 2021
@adizere adizere mentioned this pull request Apr 30, 2021
Merged
5 tasks
adizere added a commit that referenced this pull request May 3, 2021
@adizere @leejw51crypto @leejw51
Fix for chain_version parsing when chain identifier has multiple da…
340224b 
…shes (#884)

* Solution: use the last digit (fix #878) (#879)

use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>

* Doc tests and FMT

* Changelog

Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Co-authored-by: jongwhan lee <leejw51@gmail.com>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere @leejw51crypto @leejw51
Fix for chain_version parsing when chain identifier has multiple da…
925545a 
…shes (informalsystems#884)

* Solution: use the last digit (fix #878) (informalsystems#879)

use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>

* Doc tests and FMT

* Changelog

Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Co-authored-by: jongwhan lee <leejw51@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere requested changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: if chanid includes 2 or more '-' , chain_version always returns 0
3 participants
@leejw51crypto @adizere @leejw51