Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for chain_version parsing when chain identifier has multiple dashes #884

Merged
merged 3 commits into from
May 3, 2021
Merged

Fix for chain_version parsing when chain identifier has multiple dashes #884

merged 3 commits into from
May 3, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Apr 30, 2021 •
edited
Loading

Co-authored-by: jongwhan lee.

This is the continuation of the work from #879.
Closes: cosmos/ibc-rs#80

Description

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@leejw51crypto @leejw51
Solution: use the last digit (fix #878) (#879)
38ee7a4 
use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>
@adizere adizere changed the title Solution: use the last digit (fix #878) (#879) Fix for chain_version parsing when chain identifiers has multiple dashes Apr 30, 2021
@adizere adizere marked this pull request as ready for review April 30, 2021 17:38
@adizere adizere changed the title Fix for chain_version parsing when chain identifiers has multiple dashes Fix for chain_version parsing when chain identifier has multiple dashes Apr 30, 2021
@adizere adizere merged commit 340224b into master May 3, 2021
@adizere adizere deleted the adi/879 branch May 3, 2021 09:40
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere @leejw51crypto @leejw51
Fix for chain_version parsing when chain identifier has multiple da…
925545a 
…shes (informalsystems#884)

* Solution: use the last digit (fix #878) (informalsystems#879)

use expect

Co-authored-by: jongwhan lee <leejw51@gmail.com>

* Doc tests and FMT

* Changelog

Co-authored-by: Jongwhan Lee <51560997+leejw51crypto@users.noreply.github.com>
Co-authored-by: jongwhan lee <leejw51@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adizere @ancazamfir @leejw51crypto