fix(notifications): emit detailed recording info #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird unit test failure: #812 . |
|
This PR/issue depends on: |
jan-law
reviewed
Feb 7, 2022
There was a problem hiding this comment.
This is working well when tested with cryostatio/cryostat-web#366
src/main/java/io/cryostat/recordings/RecordingArchiveHelper.java
Outdated
Show resolved
Hide resolved
emit same information on websocket
emit same information on websocket
do not overload RecordingDeleted category for both active and archived recordings
andrewazores
force-pushed
the
archive-notification-message
branch
from
5acba12 to
2924efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an recording is archived, an archived recording is deleted, or a recording is re-uploaded into the archive, emit a notification containing an
ArchivedRecordingInfoobject (name, downloadUrl, reportUrl) instead of only the archived recording name.Related to cryostatio/cryostat-web#344
Depends on cryostatio/cryostat-web#366