Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(archivedrecordings): use notifications to update state without query #366

Merged
merged 5 commits into from
Feb 7, 2022
Merged

fix(archivedrecordings): use notifications to update state without query #366

merged 5 commits into from
Feb 7, 2022

Conversation

andrewazores
Copy link
Member

Fixes #344

@andrewazores andrewazores mentioned this pull request Feb 4, 2022
Merged
jan-law
jan-law reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my last comment, code looks good

src/app/Shared/Services/NotificationChannel.service.tsx Show resolved Hide resolved
@andrewazores
fix incorrect property access
ccd7779
@andrewazores
correct notification categories
c873e4c 
categories previously used inconsistent naming, and deletion of active and archived recordings were overloaded into a single category
@andrewazores
formatting
3f5ec84
hareetd
hareetd approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out with the corresponding backend and the updated notification categories are looking good. Archived recordings state is updating properly as well.

@andrewazores andrewazores merged commit 4804e45 into cryostatio:main Feb 7, 2022
@andrewazores andrewazores deleted the archived-recording-refresh-notification branch February 7, 2022 20:38
This was referenced Feb 9, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law approved these changes

@hareetd hareetd hareetd approved these changes

Assignees
No one assigned
Labels
fix
Projects
No open projects
2.1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archived recordings table view does not update on notification
3 participants
@andrewazores @hareetd @jan-law