-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create metadata table #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adilahiri thanks for starting this. Can you make sure all columns from v11 are represented in the readme? Eg - the methylation information. Thanks!
@jharenza thank you for pointing out the missing methylation columns. I have added them into the README now. Following are the extra columns that have been added to README. I have added the description based on my understanding, but they can be improved especially for the classification scores by specifying the type of score (accuracy, F-1, roc_auc_score etc).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments, I will commit, rerun, and approve this so we can hand off to NCI
I will merge this without checks since it doesn't run in GA |
Purpose/implementation Section
What scientific question is your analysis addressing?
Create Table S1 for future manuscript to contain the histologies file along with a README
What was your approach?
Adapted code from:
https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/master/tables/output_tables.Rmd
What GitHub issue does your pull request address?
Issue#459
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review TableS1-histologies.xlsx and the script output_tables.nb.html
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Table
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.