Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create metadata table #294

Merged
merged 10 commits into from
Dec 21, 2022
Merged

Create metadata table #294

merged 10 commits into from
Dec 21, 2022

Conversation

adilahiri
Copy link

Purpose/implementation Section

What scientific question is your analysis addressing?

Create Table S1 for future manuscript to contain the histologies file along with a README

What was your approach?

Adapted code from:
https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/master/tables/output_tables.Rmd

What GitHub issue does your pull request address?

Issue#459

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Please review TableS1-histologies.xlsx and the script output_tables.nb.html

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • [ X] This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • [ X] The analytical code is documented and contains comments.

@adilahiri adilahiri marked this pull request as ready for review December 3, 2022 00:12
@ewafula ewafula requested a review from jharenza December 3, 2022 12:02
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adilahiri thanks for starting this. Can you make sure all columns from v11 are represented in the readme? Eg - the methylation information. Thanks!

@adilahiri
Copy link
Author

adilahiri commented Dec 5, 2022

@jharenza thank you for pointing out the missing methylation columns. I have added them into the README now.

Following are the extra columns that have been added to README. I have added the description based on my understanding, but they can be improved especially for the classification scores by specifying the type of score (accuracy, F-1, roc_auc_score etc).

Histology column Definition
cns_methylation_class methylation-based CNS tumour classes
cns_methylation_class_score class score
cns_methylation_subclass methylation-based CNS tumour sub-classes
cns_methylation_subclass_score subclass score
gtex_group Tissue Type
gtex_subgroup Tissue Subtype
RF_purity_ABSOLUTE purity score based on ABSOLUTE dataset
RF_purity_ESTIMATE purity score based on ESTIMATE dataset
RF_purity_LUMP purity score based on LUMP dataset

@jharenza jharenza self-requested a review December 19, 2022 20:39
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments, I will commit, rerun, and approve this so we can hand off to NCI

tables/output_tables.Rmd Outdated Show resolved Hide resolved
tables/output_tables.Rmd Outdated Show resolved Hide resolved
tables/output_tables.Rmd Outdated Show resolved Hide resolved
tables/run-manuscript-tables.sh Outdated Show resolved Hide resolved
@jharenza
Copy link
Member

I will merge this without checks since it doesn't run in GA

@jharenza jharenza merged commit b026724 into dev Dec 21, 2022
@jharenza jharenza deleted the create-metadata-table branch December 21, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants