Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update generate-mtp-tables.sh #296

Merged
merged 2 commits into from
Dec 15, 2022
Merged

update generate-mtp-tables.sh #296

merged 2 commits into from
Dec 15, 2022

Conversation

ewafula
Copy link

@ewafula ewafula commented Dec 5, 2022

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

  • Uploaded previous MTP tables in sub-folders under their respective OpenPedCan data release folders
  • Updated generate-mtp-tables.sh to upload generated tables to the appropriate mtp-tables sub-folders under the appropriate OpenPedCan data release folder

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

  • Check update to change destination directories on the s3 bucket for uploads
  • Please, no need to run the script. It uploads files to the s3 bucket run script. Want to avoid overwriting MTP v1.1 files that are manually filtered.

Is there anything that you want to discuss further?

None

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Tables and JSONL

What is your summary of the results?

All MTP tables

Reproducibility Checklist

  • [ x] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@sangeetashukla sangeetashukla self-assigned this Dec 6, 2022
Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewafula These changes look good. Approving.

@ewafula ewafula merged commit 0f2cc75 into dev Dec 15, 2022
@sangeetashukla sangeetashukla deleted the update-generate-mtp-tables branch December 22, 2022 14:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants