Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tp53_nfl_score to gencode v39 #306

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

ewafula
Copy link

@ewafula ewafula commented Jan 13, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

update tp53_nfl_score

What was your approach?

update from gencode v27 to v39

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

change in gencode input file and associated variable names

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

tables

What is your summary of the results?

rerun results in results directory

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ewafula ewafula merged commit 666ed93 into dev Jan 18, 2023
@jharenza jharenza deleted the update_tp53_nf1_score_gencode branch February 19, 2023 02:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants