-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ATRT subtype #311
Update ATRT subtype #311
Conversation
@zzgeng can you make the bash script in the ATRT subtyping module executable |
analyses/molecular-subtyping-ATRT/Archive/run-molecular-subtyping-ATRT.sh
Outdated
Show resolved
Hide resolved
Also, just to be consistent with all other modules, can you lowercase the A in Archive folder? Thanks! |
…nTargets/OpenPedCan-analysis into update_ATRT_subtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzgeng if this passes, we are good to go - updated the bash script to be executable and removed some unnecessary filter steps. I also noticed we were not collecting DGD samples in the final file, so added those to get the full cohort of ATRT here.
Purpose/implementation Section
UPDATED Analysis: ATRT subtyping
What scientific question is your analysis addressing?
Assign ATRT tumors to one of 3 subtypes:
ATRT, MYC
ATRT, SHH
ATRT, TYR
using methylation results
What was your approach?
archive current scripts 00, 01, and 02 - create an archive folder and move them there - we might want to use some of this information later for classification in the absence of methylation, but for now, we will rely only on methylation results
Create a subtyping script to subtype all PBTA and/or DGD tumor biospecimens which have matched methylation (matched on sample_id). If methylation does not exist for any ATRT samples, those biospecimens can be deemed "ATRT, To be clasified" subtype.
The above subtypes should be listed in the methylation results (similar to IHG subtyping). Use only those with scores >=0.8.
The expected table will have matched tumor DNA/RNA/methylation biospecimen IDS for all ATRTs with new subtypes or a To be classified subtype.
What GitHub issue does your pull request address?
d3b-center/ticket-tracker-OPC#496
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
OpenPedCan-analysis/analyses/molecular-subtyping-ATRT/ATRT_subtyping.R
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
OpenPedCan-analysis/analyses/molecular-subtyping-ATRT/results/ATRT_subtype_methylation.tsv
What types of results are included (e.g., table, figure)?
Table
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.