Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
We need to split generate-analysis-files.sh into
generate-analysis-files.sh
andrun-for-subtyping.sh
What was your approach?
generate-analysis-files.sh
creates pre-release analysis files and uploads on s3 bucket,analysis-files-pre-release
folder for QCrun-for-subtyping.sh
creates pre-release files for subtyping, subtyping files, final release histologies.tsv, and the complete set of independent samples lists and uploads on s3 bucket,analysis-files-pre-release-commit
folder for QCWhat GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Will need to test the v12 data files
Is there anything that you want to discuss further?
Requires old files on the s3 bucket in the
analysis-files-pre-release
andanalysis-files-pre-release-commit
folders to be deleted.Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Pre-release data files
What is your summary of the results?
Will be available on the s3 bucket
analysis-files-pre-release
andanalysis-files-pre-release-commit
folders for QC and respective OPC analyses modules.Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.