Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split generate-analysis-files.sh #313

Merged
merged 4 commits into from
Feb 7, 2023
Merged

split generate-analysis-files.sh #313

merged 4 commits into from
Feb 7, 2023

Conversation

ewafula
Copy link

@ewafula ewafula commented Feb 4, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

We need to split generate-analysis-files.sh into generate-analysis-files.sh and run-for-subtyping.sh

What was your approach?

  • generate-analysis-files.sh creates pre-release analysis files and uploads on s3 bucket, analysis-files-pre-release folder for QC
  • run-for-subtyping.sh creates pre-release files for subtyping, subtyping files, final release histologies.tsv, and the complete set of independent samples lists and uploads on s3 bucket, analysis-files-pre-release-commit folder for QC

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Will need to test the v12 data files

Is there anything that you want to discuss further?

Requires old files on the s3 bucket in the analysis-files-pre-release and analysis-files-pre-release-commit folders to be deleted.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Pre-release data files

What is your summary of the results?

Will be available on the s3 bucket analysis-files-pre-release and analysis-files-pre-release-commit folders for QC and respective OPC analyses modules.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@ewafula ewafula merged commit f4083ec into dev Feb 7, 2023
@jharenza jharenza deleted the split-generate-analysis branch February 11, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants