-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated analysis: Update mol subtyping integrate to include ATRT + NBL #315
Conversation
analyses/molecular-subtyping-ATRT/results/ATRT-molecular-subtypes.tsv
Outdated
Show resolved
Hide resolved
Can you pull |
analyses/molecular-subtyping-pathology/pathology_free_text-subtyping-jxg.nb.html
Show resolved
Hide resolved
I have now merged the NBL subtyping PR, so after conflicts are resolved, you can go ahead and merge dev into this |
@ewafula and @zzgeng I made some updates to this 01-compile-subtyping-results.Rmd
I will approve, but would be good to have one more set of eyes on |
@jharenza, just checked |
I was just looking into that, too - I think this is a special case, bc we had to consult with pathology. on these since they are "poorly differentiating" - they may all be manually updated in the clinical and path feedback file. Will check.
Let me check this - this module binds with the results from the module, so possible they are missed there, we might need to update, but will check. |
chordoma will be updated in pathology feedback: https://github.com/PediatricOpenTargets/OpenPedCan-analysis/blob/efc08161115c2a53e740a46b9f5630d5d1450fdb/analyses/molecular-subtyping-pathology/results/compiled_molecular_subtypes_with_clinical_pathology_feedback_and_report_info.tsv Possibly we can rework this later to not be in this module. |
@jharenza, one more question. All BS_IDs not subtyped (to be classified) don't have
Not a big deal - should this be kept consistent in the
Maybe, mutate |
For these, I updated - missed this bc of the TP53 status so I updated the code to just grepl the alteration determining the subtype for all of HGG. For the neurocytoma ones, they will not get an integrated dx, only a harm dx - since the subtype is not based on molecular data, just the primary site and free text. Ohh good catch again about to be classified. Let me change that in the NBL module - it is important for other things which escape me now! |
@ewafula ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jharenza, this now looks ok to me. Thank you for updating.
Approving
…r_subtyping_ATRT
Purpose/implementation Section
What scientific question is your analysis addressing?
The NBL and ATRT subtypes need to be added to this so that they show up in the final histology file.
What was your approach?
Add ATRT subtyping results into histology file
What GitHub issue does your pull request address?
d3b-center/ticket-tracker-OPC#504
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
analyses/molecular-subtyping-pathology/01-compile-subtyping-results.Rmd
analyses/molecular-subtyping-integrate/results/histologies.tsv
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Need to wait until #264 is merged
Results
What types of results are included (e.g., table, figure)?
Table
What is your summary of the results?
Add ATRT subtyping results into histologies file.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.