Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fusion-putative-oncogenic.tsv file with annoFuseData #317

Merged
merged 6 commits into from
Feb 11, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Feb 10, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update fusion with new annoFuseData

What was your approach?

Rerun fusion-filtering module

What GitHub issue does your pull request address?

follow this PR #316 #316

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

analyses/fusion_filtering/results/fusion-putative-oncogenic.tsv

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Update fusion-putative-oncogenic file with new annoFuseData

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, BS_KP735TJ6 TPM3--NTRK1 fusion kinase domain now being captured as retained. @ewafula added you to review also since I worked on this a bit.

Copy link

@ewafula ewafula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jharenza.TPM3--NTRK1 is now being captured for the BS_KP735TJ6 sample in the fusion-putative-oncogenic.tsv

@jharenza jharenza merged commit 2d2884f into dev Feb 11, 2023
@jharenza jharenza deleted the update_fusion_annofuse branch February 11, 2023 19:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants