Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
Create Open Targets Platform v22.11 Target (core annotations for targets) and Disease/Phenotype (core annotations for diseases and phenotypes) tables to utilize for filtering MTP .v1.2 tables and O API OPC v12 data files.
What scientific question is your analysis addressing?
Creating a disease/phenotype table for use with v12 data files
What was your approach?
Download the files to scratch and then convert them from json to csv. Store the csv files in
/home/ubuntu/volume/OpenPedCan-analysis/scratch/mtp-csv
folder and then use R to pull out the needed data. Then write that data to a tsv file in~/volume/OpenPedCan-analysis/analyses/mtp-annotations/results
.What GitHub issue does your pull request address?
A missing table that contains all of the disease and phenotype information for downstream v12 processing
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
~/volume/OpenPedCan-analysis/analyses/mtp-annotations01-mtp-annotations.R
~/volume/OpenPedCan-analysis/analyses/mtp-annotationsrun-mtp-annotations.sh
~/volume/OpenPedCan-analysis/analyses/mtp-annotations/resultsmtp-disease-mapping.tsv
~/volume/OpenPedCan-analysis/analyses/mtp-annotations/resultsmtp-target-mapping.tsv
Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Two tables
~/volume/OpenPedCan-analysis/analyses/mtp-annotations/resultsmtp-disease-mapping.tsv
~/volume/OpenPedCan-analysis/analyses/mtp-annotations/resultsmtp-target-mapping.tsv
What is your summary of the results?
Two files that contain the
Hugo gene_symbol to Ensemble gene_id to Ensemble transcript_id
andEFO to MONDO
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.