Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dasel file format converter to dockerfile #320

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Conversation

ewafula
Copy link

@ewafula ewafula commented Feb 14, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update Dockerfile

What was your approach?

What GitHub issue does your pull request address?

  • Add dasel to Dockerfile
  • Dasel supports conversion between formats. - JSON, TOML, YAML, XML, and CSV data formats.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

NA

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

YES

Results

What types of results are included (e.g., table, figure)?

Dockerfile

What is your summary of the results?

Dockerfile

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@ewafula
Copy link
Author

ewafula commented Feb 14, 2023

@sangeetashukla, can please review this PR? Update to need for reviewing upcoming PR later today.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tie this to a specific release for reproducibility ?

@ewafula
Copy link
Author

ewafula commented Feb 15, 2023

@jharenza, I have included the release version number.

Dockerfile Outdated Show resolved Hide resolved
@jharenza jharenza self-requested a review February 15, 2023 02:19
@jharenza jharenza merged commit 98af60c into dev Feb 15, 2023
@jharenza jharenza deleted the add-dasel-to-dockerfile branch February 15, 2023 07:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants