Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude descriptions from MTP disease mapping #339

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

ewafula
Copy link

@ewafula ewafula commented Mar 14, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

  • excluded disease description in mtp-diseases-mapping.tsv.
  • some are formatted over several lines
  • some are several paragraphs longs
  • Only retaining id, name, and dbXRefs columns because at no time is the disease description going to be utilized

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Check to make sure the disease mapping file is formatted correctly

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Tables

What is your summary of the results?

  • mtp-diseases-mapping.tsv.gz
  • mtp-targets-mapping.tsv.gz

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Collaborator

@sangeetashukla sangeetashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewafula I reviewed the changes, and verified the results format in the file.
input_dir <- "results" mtp_disease <- read_tsv(file.path(input_dir,"mtp-diseases-mapping.tsv.gz")) ID_type <- strsplit(mtp_disease$id,"_") %>% lapply(., [[, 1) %>% unlist() %>% unique()

`

ID_type
[1] "DOID" "EFO" "HP" "MONDO" "Orphanet" "GO" "OBA" "OTAR" "OBI" "OGMS" "NCIT" "MP"

`

This makes sense now. Approving.

@ewafula
Copy link
Author

ewafula commented Mar 14, 2023

@sangeetashukla, thank you for reviewing!

Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Approving!

@ewafula
Copy link
Author

ewafula commented Mar 14, 2023

Look good to me! Approving!

@zzgeng, thank you for reviewing!

@ewafula ewafula merged commit 6e53918 into dev Mar 14, 2023
@ewafula ewafula deleted the update-mpt-annot branch March 21, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants