Part 3 v6 release: Update download script and doc #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaonkar6
changed the title
jharenza
requested changes
Jul 1, 2021
There was a problem hiding this comment.
Thanks @kgaonkar6 - will you update the release notes in the download per those updates?
The download otherwise works, but I would like to do one check on the histologies file later when I get a chance.
Co-authored-by: Jo Lynne Rokita <jolynnerokita@d3b.center>
Co-authored-by: Jo Lynne Rokita <jolynnerokita@d3b.center>
jharenza
reviewed
Jul 1, 2021
Co-authored-by: Jo Lynne Rokita <jolynnerokita@d3b.center>
jharenza
reviewed
Jul 1, 2021
|
Updated the following file to match our histologies files plus updates coming in d3b-center/ticket-tracker-OPC#48: |
|
@kgaonkar6 I updated the release notes as well, and the md5sums for both efo and release files, and download checks out. Histologies should be the last update. |
|
ok updated |
This was referenced Jul 2, 2021
Merged
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Only merge this PR once #43 #44 is reviewed and merged.
Purpose/implementation Section
What scientific question is your analysis addressing?
Data release v6
What GitHub issue does your pull request address?
d3b-center/ticket-tracker-OPC#57
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Please review documentation for release in
docfolderWhich areas should receive a particularly close look?
Data Release Checklist