Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12 independent sample lists (15/N) #344

Merged
merged 16 commits into from
Apr 29, 2023
Merged

Conversation

ewafula
Copy link

@ewafula ewafula commented Mar 22, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Create v12 independent sample list

What was your approach?

rerun updated independent-samples modules with v12 histologies files

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

check to make sure PDX and Derived cell lines are excluded

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

YEs

Results

What types of results are included (e.g., table, figure)?

tables

What is your summary of the results?

module results folder and v12 s3 bucket

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link

@atlas4213 atlas4213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code successfully runs and the logic looks good. Approving

Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PDX and Derived Cell line are excluded from the results. The code works fine. Approving!

@jharenza jharenza merged commit a278add into v12-integrate Apr 29, 2023
@jharenza jharenza deleted the v12-independent-samples branch April 29, 2023 00:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants