Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Duplicates in
fusion_filtering
results caused by incomplete merge of fusion calls between ARRIBA and STARFUSION (and maybe due to multiple kinase domains).What was your approach?
What GitHub issue does your pull request address?
Ticket 533
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
In
results/fusion-putative-oncogenic.tsv
, theFusion_Type
,CalledBy
,annots
,DomainRetainedGene1A
, andDomainRetainedGene1B
all had duplicates resolved. ForFusion_Type
andannots
, the ARRIBA annotation was used and they should only have a single value for all rows. ForCalledBy
,DomainRetainedGene1A
, andDomainRetainedGene1B
, duplicates were collapsed, so some rows will have comma-separated options.Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
table
What is your summary of the results?
fusion_filtering/results/fusion-putative-oncogenic.tsv
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.