Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fusion_filtering duplicates #353

Merged
merged 10 commits into from
Apr 24, 2023
Merged

fusion_filtering duplicates #353

merged 10 commits into from
Apr 24, 2023

Conversation

kelseykeith
Copy link

Purpose/implementation Section

What scientific question is your analysis addressing?

Duplicates in fusion_filtering results caused by incomplete merge of fusion calls between ARRIBA and STARFUSION (and maybe due to multiple kinase domains).

What was your approach?

What GitHub issue does your pull request address?

Ticket 533

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

In results/fusion-putative-oncogenic.tsv, the Fusion_Type, CalledBy, annots, DomainRetainedGene1A, and DomainRetainedGene1B all had duplicates resolved. For Fusion_Type and annots, the ARRIBA annotation was used and they should only have a single value for all rows. For CalledBy, DomainRetainedGene1A, and DomainRetainedGene1B, duplicates were collapsed, so some rows will have comma-separated options.

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

table

What is your summary of the results?

fusion_filtering/results/fusion-putative-oncogenic.tsv

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@ewafula ewafula self-requested a review April 24, 2023 16:33
@ewafula ewafula merged commit 1c988e3 into v12-analysis-files Apr 24, 2023
@jharenza jharenza deleted the ff-bugs branch December 16, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants