update Table S1 - histologies README #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Four rows in readme do not match the columns in histologies file. |
|
Thanks so much for catching those @zzgeng ! Reran with the updates. |
|
@zzgeng this is ready for re-review |
sangeetashukla
requested changes
May 4, 2023
There was a problem hiding this comment.
@jharenza I downloaded v12 data, and ran the script tables/output_tables.Rmd.
I used the results/TableS1-histologies.xlsx file to compare the column values from histologies.tsv
I found clinical_status_at_event column present in the histologies.tsv file but missing in the excel.
|
thanks so much @sangeetashukla - added, can you re-review? |
sangeetashukla
approved these changes
May 4, 2023
|
Merging without checks, as this does not get run in GA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR adds/edits columns for v12 histologies and reruns the histologies file README script
What was your approach?
Added new columns and definitions, renamed old methylation columns to new values.
What GitHub issue does your pull request address?
NA
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Double check all columns exist in this file, nothing looks awry
Is there anything that you want to discuss further?
no
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
Excel table with histologies file readme
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.