Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #36

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Update Dockerfile #36

merged 1 commit into from
Jul 1, 2021

Conversation

logstar
Copy link

@logstar logstar commented Jun 30, 2021

Purpose/implementation Section

What scientific question is your analysis addressing?

Install mygene for querying gene IDs and symbols from mygene.info.

mygene.info seems to be actively maintained. The query results are more comprehensive than biomaRt.

Relevant URLs:

mygene.info is suggested by @taylordm and @jharenza.

What was your approach?

Update Dockerfile by adding

RUN ./install_bioc.r \
    mygene

What GitHub issue does your pull request address?

In d3b-center/ticket-tracker-OPC#64, additional gene full names and RefSeq Protein IDs are required to be added to the MAF table.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Dockerfile updates.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes.

Results

What types of results are included (e.g., table, figure)?

NA

What is your summary of the results?

NA

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.

Install mygene for querying gene IDs and symbols from mygene.info.

mygene.info seems to be actively maintained. The query results are more comprehensive
than [biomaRt](https://bioconductor.org/packages/release/bioc/html/biomaRt.html).

Relevant URL:
- http://mygene.info/about
- https://bioconductor.org/packages/release/bioc/html/mygene.html
@logstar logstar requested a review from kgaonkar6 June 30, 2021 17:53
Copy link

@kgaonkar6 kgaonkar6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@logstar
Copy link
Author

logstar commented Jun 30, 2021

@kgaonkar6 Thank you for reviewing! Can you merge this PR? I am not authorized to merge.

@kgaonkar6 kgaonkar6 merged commit 419e50b into dev Jul 1, 2021
@kgaonkar6 kgaonkar6 deleted the logstar/update-dockerfile branch July 1, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants