Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring molecular-subtyping-EPN module #363

Merged
merged 8 commits into from
Jun 5, 2023
Merged

Refactoring molecular-subtyping-EPN module #363

merged 8 commits into from
Jun 5, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented May 10, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update molecular-subtyping-EPN module to include a script to generate JSON file for sample selection.

What was your approach?

Add script to generate json file, which includes exact_path_dx and path_free_text_exact for CRANIO sample subsetting.

What GitHub issue does your pull request address?

d3b-center/ticket-tracker-OPC#543

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

00-EPN-select-pathology-dx.R
epn-subset/EPN_subtyping_path_dx_strings.json

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

JSON

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link

@atlas4213 atlas4213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code logic looks good and the module compiled successfully.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions

@jharenza jharenza self-requested a review June 1, 2023 20:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants