Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove snv consensus module "snv-callers" #370

Merged
merged 7 commits into from
May 24, 2023
Merged

remove snv consensus module "snv-callers" #370

merged 7 commits into from
May 24, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented May 19, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

This PR removes the snv-callers module since it is not being used in OPC. I have also updated the analysis module README to remove this, but link to the OpenPBTA module for reference.

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

I see gencode.v27.primary_assembly.annotation.bed in the list of files for tmb-calculation here - did we update this? I do not see in data release.

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from ewafula May 19, 2023 20:55
@jharenza jharenza merged commit 21e10e5 into dev May 24, 2023
@jharenza jharenza deleted the rm-snv-consensus branch May 24, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants