Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tmb-calculation README #371

Merged
merged 4 commits into from
May 24, 2023
Merged

update tmb-calculation README #371

merged 4 commits into from
May 24, 2023

Conversation

ewafula
Copy link

@ewafula ewafula commented May 22, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update tmb-calculation

What was your approach?

Update module README

What GitHub issue does your pull request address?

d3b-center/ticket-tracker-OPC#553

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Review updated README

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

NA

What is your summary of the results?

NA

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to clarify some things, and question about targeted panel

analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
analyses/tmb-calculation/README.md Outdated Show resolved Hide resolved
in the interest of getting this out for public consumption I am committing my suggested changes
@jharenza
Copy link
Member

merging without CI, documentation update only

@jharenza jharenza merged commit 56b0b50 into dev May 24, 2023
@jharenza jharenza deleted the update-tmb-calc-readme branch May 24, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants