-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerun all of the modules with the new docker image #372
Conversation
…ts/OpenPedCan-analysis into updated-docker-reruns
@ewafula is this done/complete? Also noticed cnv consensus wasn't in here, was that bc of the known issue or just forgotten - in any case, you did test it, so yay! |
Yes, this one is done. I intentionally left our the cnv consensus module because I was focused on debugging the the snakemake workflow. Turns out it was docker issue associated Debian Stretch limitations. Can be merged. I also left out the cnv consensus module from the repo README update for the data release process because you had suggested that it needs to wrapped in CWL and run on CAVATICA with as pre-release workflows. |
Ok thanks- can you put into the release readme for now then since fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the TP53 changes are happening because we don't have a seed set for this, and we should, though it does not affect the overall call for these samples. I will create a ticket for this.
Purpose/implementation Section
What scientific question is your analysis addressing?
Rerun all of the modules with the new docker image.
What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Provide suggestions if any other module apart from those listed below Utilized in OPC need to be included and checked for updates:
[Dockerfile]
[Rerun data pre-release analysis modules]
[Rerun molecular subtyping and addition data pre-release module]
[Rerun data post-release modules]
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
YES
Results
What types of results are included (e.g., table, figure)?
Module results that can be uploaded to GitHub with PR
What is your summary of the results?
Successful module runs with new docker image
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.