Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include data release process in the repo README #376

Merged
merged 11 commits into from
Jun 13, 2023
Merged

Conversation

ewafula
Copy link

@ewafula ewafula commented Jun 6, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Include the OpenOpedCan data release analysis process in repo README

What was your approach?

Included description and table of associated modules

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Check if text makes sense

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

NA

What is your summary of the results?

NA

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@ewafula ewafula requested a review from jharenza June 6, 2023 23:17
@ewafula ewafula changed the title Include data release analysis process in the repo README Include data release process in the repo README Jun 6, 2023
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this documentation, @ewafula ! Can you add one more bit - the QC script which is run before generating analysis files (on the primary matrices, correct?). Thanks

@jharenza jharenza requested a review from zzgeng June 7, 2023 17:22
@jharenza
Copy link
Member

documentation only, can merge without GA

@jharenza jharenza merged commit 42f5309 into dev Jun 13, 2023
@jharenza jharenza deleted the data-release-process branch June 13, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants