Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data release analysis process workflow scripts #380

Merged
merged 5 commits into from
Jun 15, 2023

Conversation

ewafula
Copy link

@ewafula ewafula commented Jun 9, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update data release analysis process workflow scripts

What was your approach?

  • update generate-analysis-files.sh to include generate cnv consensus file
  • clean up run-for-subtyping.sh to match the current molecular subtyping process that also includes generating additional release files - full histologies file and independent sample lists

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Test the scripts on EC2

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Tables

What is your summary of the results?

Module results and releases and release files

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ewafula thanks for updating this- can you check out my comment below. Also odd- those errors did not occur in the latest EPN and NBL PRs. 🤔

scripts/run-for-subtyping.sh Show resolved Hide resolved
@jharenza
Copy link
Member

merge without GA, these are not run in GA

@jharenza jharenza merged commit f74fe6f into dev Jun 15, 2023
1 check failed
@jharenza jharenza deleted the update-generate-analysis branch June 15, 2023 22:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants