Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating module per latest v12 successful run on HPC #381

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Conversation

sangeetashukla
Copy link
Collaborator

Purpose/implementation Section

Update the module scripts to ensure the changes made for v12 are captured in the final OPC repo

What scientific question is your analysis addressing?

Capture the process and scripts for executing a differential expression analysis between tumor and normal samples in pairs for each Disease(cancer_group) and Dataset(cohort) combination.

What was your approach?

  • Update column names as below:
    cohort --> Dataset
    Gene_Ensembl_ID --> targetFromSourceId
    EFO --> diseaseFromSourceMappedId
    cancer_group --> Disease
    cancer_group_Count --> Disease_Count
    cancer_group_MeanTpm --> Disease_MeanTpm

  • Make appropriate script changes and add a new script to perform a QC and ensure all the result tables are successfully generated. In case of failure, the script must also capture information on which tables were not generated.

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

This PR captures the script changes as described above, and the result of the QC script that also performs a spot check on the results produced, so that downstream analysis is more accurate.

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link

@ewafula ewafula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangeetashukla, thanks for updating. This reflects the changes we discussed, and you made on the tumor-normal DESeq2 module while working to release the v12 MTP tables.

@jharenza jharenza merged commit 2e059ec into dev Jun 10, 2023
@jharenza jharenza deleted the opc_final_deseq branch June 10, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants