Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated analysis: copy_number_consensus_call_manta to use only samples which do not have GATK CNV #410

Merged
merged 9 commits into from
Aug 23, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jun 26, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

What was your approach?

Create a script/update a script to pull in only WGS samples which are not present in the cnv-gatk.seg.gz file and run the consensus using manta SV instead.

What GitHub issue does your pull request address?

#387

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

script/missing_WGS.R
run_consensus_call.sh

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzgeng can you update the name of this output file to read cnv-consensus-manta.seg.gz and cnv-consensus-manta.tsv

@jharenza jharenza self-requested a review July 18, 2023 17:20
@jharenza
Copy link
Member

I forgot this requires an update to CI testing files to enrich for these non-GATK samples in order to pass. Will create a ticket.

@jharenza
Copy link
Member

All modules, including this one passed CI 👍

@jharenza jharenza merged commit 8efd627 into dev Aug 23, 2023
25 checks passed
@jharenza jharenza deleted the CNV_manta branch December 16, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants