Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create methyl array probes annotation module #411

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Create methyl array probes annotation module #411

merged 11 commits into from
Oct 6, 2023

Conversation

ewafula
Copy link

@ewafula ewafula commented Jun 27, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Create Illumina Infinium Human Methylation array probe annotation based on the Human Build 38 (GRCh38/hg38) and GENCODE v39 release

What was your approach?

Created OPC module for generating methyl probe annotations

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

  • Review the entire module code
  • Description of the analysis process in README
  • Docker file update to include installation of module dependencies

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

tables

What is your summary of the results?

  • results/infinium.gencode.v39.probe.annotations.bedtools.tsv.gz
  • results/infinium.gencode.v39.probe.annotations.tsv.gz

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from afarrel June 27, 2023 15:05
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but i see there is a typo in script 02 - "interect" should be "intersect".

@jharenza jharenza requested a review from rjcorb June 27, 2023 15:10
Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module runs successfully when suggested modifications are made

@ewafula
Copy link
Author

ewafula commented Jun 27, 2023

The module runs successfully when suggested modifications are made

Thank you, @rjcorb, for reviewing

@ewafula
Copy link
Author

ewafula commented Jun 28, 2023

@jharenza, @rjcorb, updated bash script check to check if Illumina methyl array probe manifest exists, and downloads from data release s3 bucket if it doesn't exist.

@jharenza jharenza requested a review from rjcorb June 28, 2023 19:25
@jharenza
Copy link
Member

Note: this is awaiting updates based on some feedback @afarrel will provide

@jharenza
Copy link
Member

jharenza commented Jul 18, 2023

From @afarrel via slack:

Gene feature annotations of methylation probes located downstream of the 3'UTR (as annotated by GTF file) should be changed from 3'UTR to either "3' downstream" or "3' downstream region" (Or something more suitable)

@ewafula
Copy link
Author

ewafula commented Jul 29, 2023

@afarrel, PR updated - 3'-UTR 1kb extension added as an additional feature to the probe annotations as you suggested.

Cc @jharenza

@jharenza jharenza requested a review from a team as a code owner August 28, 2023 12:53
Copy link

@afarrel afarrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ewafula! Everything looks good.

@jharenza jharenza merged commit 6039915 into dev Oct 6, 2023
26 checks passed
@jharenza jharenza deleted the probe-annot branch October 6, 2023 18:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants