Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis Update: merge cnv files #419

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Analysis Update: merge cnv files #419

merged 8 commits into from
Sep 28, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jul 14, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Merge cnv_gatk and cnv_manta

What was your approach?

Add a R script in analyses/copy_number_consensus_call to merge analyses/copy_number_consensus_call/results/cnv-consensus.seg.gz with analyses/copy_number_consensus_call_manta/results/cnv-consensus.seg.gz

What GitHub issue does your pull request address?

#418

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

merge_cnv_file.R
results/cnv-consensus_full.seg.gz

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza
Copy link
Member

@zzgeng this one has conflicts which need to be resolved

@zzgeng zzgeng requested a review from a team as a code owner August 24, 2023 19:25
@jharenza jharenza merged commit 38addd3 into dev Sep 28, 2023
25 checks passed
@jharenza jharenza deleted the cnv_merge branch September 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants