Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrich cnv non-GATK samples #431

Merged
merged 3 commits into from
Aug 23, 2023
Merged

enrich cnv non-GATK samples #431

merged 3 commits into from
Aug 23, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Aug 17, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Enrich the testing file with two non-GATK samples BS_A9Q65W4Q and BS_JTNTWJMD

What was your approach?

Add these two samples to cnv testing files

What GitHub issue does your pull request address?

#421

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

analyses/create-subset-files/01-get_biospecimen_identifiers.R

Is there anything that you want to discuss further?

Have not uploaded the testing files to S3 yet. Will do that when

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

analyses/create-subset-files/biospecimen_ids_for_subset.RDS

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - go ahead and upload these testing files to the testing folder!

@jharenza
Copy link
Member

testing with new CI files 🤞

@jharenza jharenza self-requested a review August 23, 2023 00:12
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 all modules pass

@jharenza jharenza merged commit 502fcbf into dev Aug 23, 2023
2 checks passed
@jharenza jharenza deleted the enrich_sample branch August 23, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants