Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: change LGG methylation subtyping #433

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Aug 21, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

dkfz updates the methylation subtyping. Based on their description, PA_INF is equal to LGG, BRAF/MAPK.

What was your approach?

Change analyses/molecular-subtyping-LGAT/01-subset-files-for-LGAT.Rmd

What GitHub issue does your pull request address?

#432

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

analyses/molecular-subtyping-LGAT/01-subset-files-for-LGAT.Rmd

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza self-requested a review August 23, 2023 00:53
@zzgeng zzgeng requested a review from a team as a code owner August 24, 2023 16:38
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@jharenza jharenza merged commit 0d4a5ba into dev Aug 31, 2023
26 checks passed
@jharenza jharenza deleted the LGG_subtype_methyl branch August 31, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants