Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Reduce docker size #440

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Analysis update: Reduce docker size #440

merged 10 commits into from
Oct 5, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 3, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Recent GitHub CI does not work, potentially due to the large size of the docker image. Remove unused packages from dockerfile to reduce the size of the docker file.

What was your approach?

What GitHub issue does your pull request address?

#425

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Dockerfile

Is there anything that you want to discuss further?

I commented out the packages that are not used in current analyses. Once this PR has been tested and approved, I will delete these to make dockerfile more presentable.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 3, 2023 20:36
@zzgeng zzgeng requested a review from jharenza October 4, 2023 17:30
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ! once this passes again (had to update branch), feel free to merge. In the meantime, you can merge this branch into the next one to get it going.

Dockerfile Show resolved Hide resolved
@jharenza jharenza merged commit 0e6aad3 into dev Oct 5, 2023
25 checks passed
@jharenza jharenza deleted the zzgeng/docker_reduce branch October 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants