Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analysis: Fix a typo in molecular_subtyping_HGG script #446

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 11, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

fix a typo in molecular_subtyping_HGG 03-HGG-molecular-subtyping-cnv.Rmd script.

What was your approach?

In analyses/molecular-subtyping-HGG/03-HGG-molecular-subtyping-cnv.Rmd line 177, change PTEN_focal_status = replace_na(PDGFRA_focal_status, "neutral"), to PTEN_focal_status = replace_na(PTEN_focal_status, "neutral"),.

What GitHub issue does your pull request address?

#423

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

molecular subtyping results and histologies.tsv file

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 11, 2023 21:10
@jharenza jharenza merged commit 6567c90 into dev Oct 11, 2023
22 checks passed
@jharenza jharenza deleted the zzgeng/HGG_typo branch October 11, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants