Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Add CRANIO subtyping workflow to README #464

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Nov 10, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Add CRANIO subtyping workflow to README

What was your approach?

Add CRANIO subtyping workflow to README

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

CRANIO subtyping workflow

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner November 10, 2023 21:46
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in second column second yellow box "doe".

I think that we also removed the age constriction here since it was not available for all samples, but can you double check?

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add methylation, perhaps readme also needs an update

# we will add methyl subtypes in the absence DNA results or in the case of discrepant results

@zzgeng zzgeng requested a review from jharenza November 27, 2023 17:22
@zzgeng zzgeng merged commit 9de7384 into dev Nov 28, 2023
0 of 22 checks passed
@jharenza jharenza deleted the add_CRANIO_workflow branch December 16, 2023 22:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants