-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Analysis: add Pineoblastoma subtype module #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @zzgeng - I made some minor updates to the subtype names, and updated the readme. I also removed PNET since it was pulling PNET in the absence of path free text being a pineoblastoma and we want to subtype those in embryonal separately. I also updated pathology and integrate modules and ran those. Can you do a once over and check this, AND create a flow diagram for this? Then, we can get it merged?
analyses/molecular-subtyping-pathology/results/compiled_molecular_subtypes.tsv
Outdated
Show resolved
Hide resolved
Quick question- maybe I missed it- in your flow, O think we might want path dx == pineoblastoma OR free text contains any of those ? That way PNET would come in only if we had a free text pineoblastoma.. |
When I got |
Yea I think let's make the cohort comprehensive; maybe grepl instead of exact matches on all variations of pineoblastoma ? |
Purpose/implementation Section
What scientific question is your analysis addressing?
add Pineoblastoma subtype module
What was your approach?
add Pineoblastoma subtype module using methylation subclass
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
analyses/molecular-subtyping-PB/
Is there anything that you want to discuss further?
need to update molecular-subtype-pathology and molecular-subtype-integreate
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.