Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclude path diagnosis of PB in EMB subtyping module #479

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Dec 8, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Forgot to update the workflow diagram when we did the removal of PB from EMB the other day.

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from a team as a code owner December 8, 2023 16:10
@jharenza jharenza requested a review from zzgeng December 8, 2023 16:10
@jharenza
Copy link
Member Author

jharenza commented Dec 8, 2023

docs only, do not need GA

@jharenza jharenza merged commit 4802aa0 into dev Dec 8, 2023
22 of 23 checks passed
@jharenza jharenza deleted the update-emb-visual branch December 8, 2023 16:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants