Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readmes for deprecated modules, remove unused modules #481

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Dec 9, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR updates the readmes for the deprecated MTP modules, removes modules no longer used in either OpenPBTA/OpenPedCan and will not be used in the future, and adds PB subtyping to the analysis readme since it was missed.

What was your approach?

Closes #426

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from a team as a code owner December 9, 2023 19:44
@jharenza jharenza requested a review from zzgeng December 9, 2023 19:49
@jharenza
Copy link
Member Author

jharenza commented Dec 9, 2023

only documentation updates.

| [long-format-table-utils](https://github.com/PediatricOpenTargets/OpenPedCan-analysis/tree/master/analyses/long-format-table-utils) (**DEPRECATED**) | `ensg-hugo-rmtl-mapping.tsv` `analyses/fusion_filtering/references/genelistreference.txt` `efo-mondo-map.tsv` `uberon-map-gtex-group.tsv` `uberon-map-gtex-subgroup.tsv` | Functions and scripts for handling long-format tables | No | `annotator/annotation-data/ensg-gene-full-name-refseq-protein.tsv` `annotator/annotation-data/oncokb-cancer-gene-list.tsv` | Yes | GitHub | N/A |
| [methylation-preprocessing](https://github.com/PediatricOpenTargets/OpenPedCan-analysis/tree/master/analyses/methylation-preprocessing) (**DEPRECATED**) | `TARGET_Normal_MethylationArray_20160812.sdrf.txt` `TARGET_NBL_MethylationArray_20160812.sdrf.1.txt` `TARGET_NBL_MethylationArray_20160812.sdrf.2.txt` `TARGET_CCSK_MethylationArray_20160819.sdrf.txt` `TARGET_OS_MethylationArray_20161103.sdrf.txt` `TARGET_WT_MethylationArray_20160831.sdrf.txt` `TARGET_AML_MethylationArray_20160812_450k.sdrf.1.txt` `TARGET_AML_MethylationArray_20160812_450k.sdrf.2.txt` `TARGET_AML_MethylationArray_20160812_27k.sdrf.1.txt` `TARGET_AML_MethylationArray_20160812_27k.sdrf.2.txt` `TARGET_AML_MethylationArray_20160812_27k.sdrf.3.txt` `manifest_methylation_CBTN_20220410.1.csv` `manifest_methylation_CBTN_20220410.2.csv` `manifest_methylation_CBTN_20220410.3.csv` `manifest_methylation_CBTN_20220410.4.csv` | Preprocess probe hybridization intensity values of selected methylated and unmethylated cytosine (CpG) loci into usable methylation measurements for the Pediatric Open Targets, OpenPedCan-analysis raw DNA methylation array datasets. | No | N/A | Yes | Cavatica | N/A |
| [methylation-summary](https://github.com/PediatricOpenTargets/OpenPedCan-analysis/tree/master/analyses/methylation-summary) (**DEPRECATED**) | `infinium.gencode.v39.probe.annotations.tsv.gz` `independent-specimens.rnaseqpanel.eachchort.tsv` `independent-specimens.methyl.eachcohort.tsv` `gene-expression-rsem-tpm-collapsed.rds` `rna-isoform-expression-rsem-tpm.rds` `methyl-beta-values.rds` `efo-mondo-map.tsv` `histlogies.tsv` | Summarize preprocessed Illumina Infinium Human Methylation array measurements produced by the OpenPedCan methylation preprocessing module and Illumina infinium methylation array CpG probe coordinates. | No | N/A | No | aws | N/A |
| [molecular-subtyping-ATRT](https://github.com/PediatricOpenTargets/OpenPedCan-analysis/tree/master/analyses/molecular-subtyping-ATRT) | `histologies.tsv` | Molecular subtyping of ATRT samples | No | NA | GitHub | N/A | |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here should be histologies-base.tsv

analyses/README.md Outdated Show resolved Hide resolved
analyses/gene_match/README.md Outdated Show resolved Hide resolved
@jharenza jharenza requested a review from zzgeng December 11, 2023 17:54
Copy link

@zzgeng zzgeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Approving!

@jharenza
Copy link
Member Author

docs only, GA not required

@jharenza jharenza merged commit 3cf1e3a into dev Dec 11, 2023
3 of 23 checks passed
@jharenza jharenza deleted the archive-modules branch December 11, 2023 20:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated analysis: Delete/archieve the unused modules
2 participants