Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Incorporate the feedback of HOPE non-HGG samples for v13 #484

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Dec 12, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

In HOPE cohort, some samples are not HGG and we got feedback from pathologist.
This PR is to incorporate the feedback to histologies file

What was your approach?

Incorporate the feedback of HOPE non-HGG samples for v13

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

analyses/molecular-subtyping-pathology/04-incorporate-pathology-feedback.Rmd

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

This script should run with v13 data

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner December 12, 2023 17:11
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates to this - the sarcomas were not EWS, but rather a high grade sarcoma. The CNS BCOR is an embryonal tumor. I also went back and updated the HGG module to include the BRAF p.V640E alteration since we have that in v12. We can remove that snippet in v13.

@jharenza jharenza merged commit 029baa6 into dev Dec 15, 2023
23 checks passed
@jharenza jharenza deleted the HOPE_pathology branch December 15, 2023 02:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants