-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run mutational signatures on v13 #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these results are blank and thus plots are wonky. In addition, the plot for script 04 did not print, likely because of the empty files.... Can you investigate?
This reverts commit d8521bb.
@zzgeng I am ok if you write a shell ifelse to skip 04 script for CI - that was very project specific for the OpenPBTA paper anyway ... however, can you also add the tumor only sample maf here? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked these results against v12 mut sigs and see excellent concordance (average inter-version correlation = 1 across all samples). Approving!
Purpose/implementation Section
What scientific question is your analysis addressing?
Rerun
mutational signature
module.What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.