Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mutational signatures on v13 #540

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Run mutational signatures on v13 #540

merged 8 commits into from
Feb 9, 2024

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jan 20, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

Rerun mutational signature module.

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner January 20, 2024 01:38
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these results are blank and thus plots are wonky. In addition, the plot for script 04 did not print, likely because of the empty files.... Can you investigate?

@jharenza jharenza self-requested a review January 24, 2024 19:00
@jharenza
Copy link
Member

@zzgeng I am ok if you write a shell ifelse to skip 04 script for CI - that was very project specific for the OpenPBTA paper anyway ... however, can you also add the tumor only sample maf here? thanks!

@jharenza jharenza changed the title Rerun immune mut Run mutational signatures on v13 Jan 24, 2024
Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked these results against v12 mut sigs and see excellent concordance (average inter-version correlation = 1 across all samples). Approving!

@jharenza jharenza merged commit 88fc155 into dev Feb 9, 2024
24 checks passed
@jharenza jharenza deleted the rerun_immune_mut branch February 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants